Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: protect all peers in low buckets, tag everyone else with 5 #666

Merged
merged 1 commit into from
Jun 6, 2020
Merged

feat: protect all peers in low buckets, tag everyone else with 5 #666

merged 1 commit into from
Jun 6, 2020

Conversation

Stebalien
Copy link
Member

Anything else is easy to game. This way, we remain connected to the core peers and slightly prefer all others.

Pruning doesn't really matter as we'll just reconnect. The only concern is that this will lock in 40 connections. However, that's nothing for libp2p anyways. and the DHT will create that many connections just for a single query.

@Stebalien
feat: protect all peers in low buckets, tag everyone else with 5
e14fe9b 
Anything else is easy to game. This way, we remain connected to the core peers
and slightly prefer all others.

Pruning doesn't really matter as we'll just reconnect. The only concern is that
this will lock in 40 connections. However, that's nothing for libp2p anyways.
and the DHT will create that many connections _just_ for a single query.
@Stebalien
Copy link
Member Author

Discussed with @aschmahmann on a sync call.

Rational:

  • Peer score adjustment:
    • We don't really care about remaining connected to peers in high buckets.
    • It's easy to generate peer IDs for high buckets.
    • We don't want to make it too easy for peers to connect to us and stick.
  • Protection changes: We now just protect the lowest 2 buckets. We're going to dial tons of peers anyways in the DHT, so this really won't make a difference.

@Stebalien Stebalien merged commit b3846d0 into master Jun 6, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Stebalien